[WIP] recreate the tsc crash we're seeing in mongosh #551
+258
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Jun 20, 2025
| return this._name; | ||
| } | ||
| async find( | ||
| query?: schema.Query<Document>, |
There was a problem hiding this comment.
The moment you change Document to C['schema'] it crashes. I've also changed GenericCollectionSchema to BE the schema (ie. it doesn't have a 'schema' field) and then just pass C here rather than Document, but that also crashes. Note that if you change the parameter you have to change the Promise result too in lockstep because as a test I'm just returning the query.
lerouxb
commented
Jun 20, 2025
| return this._name; | ||
| } | ||
| async find( | ||
| query?: schema.Query<C['schema']>, |
There was a problem hiding this comment.
Changing C['schema'] here (and in the return type) to Document does not crash.
There was a problem hiding this comment.
Similarly changing schema.Query to just be any here does not crash.
Anything more complicated than that breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty contrived while mirroring the generics setup/hierarchy in mongosh. I just copy pasted parts. Plan is to try and fix it here, then port the fix over.
Test it and reproduce the crash like this:
This gives you more info:
and then you can at least debug it. Right now things are kinda working at least in my reduced example.